Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in DOM renderer underline #1748

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Fix NPE in DOM renderer underline #1748

merged 1 commit into from
Oct 24, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 11, 2018

Fixes #1747

@Tyriar Tyriar added this to the 3.9.0 milestone Oct 11, 2018
@Tyriar Tyriar self-assigned this Oct 11, 2018
jerch
jerch approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tyriar Im not familiar with the DOM renderer code - just to make sure there is not bigger problem behind the scenes - Is the element supposed to be missing under some circumstances? If yes - LGTM.

@Tyriar
Copy link
Member Author

Tyriar commented Oct 12, 2018

@jerch I couldn't repro the problem unfortunately, this is just a sanity check to prevent the exception which does happen (which we will need when strict null checks are enabled anyway). If there is a bug, someone might report it someday by saying a link doesn't work and give us a repro case.

@Tyriar Tyriar merged commit ba8d341 into xtermjs:master Oct 24, 2018
@Tyriar Tyriar deleted the 1747_npe branch October 24, 2018 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerch jerch jerch approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @jerch