Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translateToString endCol default arg #1843

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Fix translateToString endCol default arg #1843

merged 1 commit into from
Dec 19, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 19, 2018

@jerch this line breaks when endCol is 0:

let length = endCol || this.length;

@Tyriar Tyriar added this to the 3.10.0 milestone Dec 19, 2018
@Tyriar Tyriar self-assigned this Dec 19, 2018
@Tyriar Tyriar requested a review from jerch December 19, 2018 00:23
jerch
jerch approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not have happened in Ada 😄
Much better now 👍

@Tyriar
Copy link
Member Author

Tyriar commented Dec 19, 2018

@jerch haha, need to tighten up compiler/lint rules 😃

@Tyriar Tyriar merged commit b39e8cf into xtermjs:master Dec 19, 2018
@Tyriar Tyriar deleted the endcol_null branch December 19, 2018 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerch jerch jerch approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @jerch