Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gitter and improve README #1856

Merged
merged 2 commits into from
Dec 23, 2018
Merged

Remove gitter and improve README #1856

merged 2 commits into from
Dec 23, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 22, 2018 •
edited
Loading

Major changes:

  • Remove links to the Gitter (see Should we shutdown the Gitter? #1838), Stack Overflow is now where we direct questions
  • Rewrote the features section to combine some points and focus more on things that make xterm.js shine
  • Removed duplicate API section
  • Removed third party addons section, it looks bad with only one, plus we kind of discourage distributing these until Custom addons #1128 is handled
  • Removed the jsdelivr badge, I don't think it's important and causes clutter, it's also not the recommended way to consume the lib

Fixes #1838

@Tyriar Tyriar added this to the 3.10.0 milestone Dec 22, 2018
@Tyriar Tyriar self-assigned this Dec 22, 2018
@Tyriar Tyriar requested a review from a team December 22, 2018 07:10
@Tyriar Tyriar mentioned this pull request Dec 22, 2018
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Dec 22, 2018

Created one to sync the website as well xtermjs/xtermjs.org#63

jerch
jerch approved these changes Dec 23, 2018
View reviewed changes
Copy link
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tyriar Tyriar merged commit 0e8a102 into xtermjs:master Dec 23, 2018
@Tyriar Tyriar deleted the readme branch December 23, 2018 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerch jerch jerch approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @jerch