-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup continuous deployment beta builds #1872
Conversation
LGTM so far. Maybe adding a note about the beta channel to the README would be useful? |
Isn't this abit unconvenient/error prone to get done right for different release cases, esp. patches? Ive never done the release things, still can image that one can easily mix up things here. Would it be easier to calculate the next version number from the existing, e.g. with the help of node-semver? |
My suggestion aligned with how VS Code does it which works pretty well, if the "error" case does happen it doesn't really matter that much, it just means that |
I'm not sure if we will want to keep this long term, but it would be a really good way to test out the process for automating stable releases. |
After thinking about it more I decided to calculate the next version based on the current version and bumping the minor version. That way we can keep the current system of committing the version number when it's being released. |
This PR will build and publish a "beta" tagged build to npm whenever new commits arrive in master.
We will need to change our workflow to update the version number immediately after releasing instead of just before a release for this the names to be right.