Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup continuous deployment beta builds #1872

Merged
merged 20 commits into from
Apr 28, 2019
Merged

Setup continuous deployment beta builds #1872

merged 20 commits into from
Apr 28, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 2, 2019

This PR will build and publish a "beta" tagged build to npm whenever new commits arrive in master.

We will need to change our workflow to update the version number immediately after releasing instead of just before a release for this the names to be right.

@Tyriar Tyriar added the work-in-progress Do not merge label Jan 2, 2019
@Tyriar Tyriar self-assigned this Jan 2, 2019
@Tyriar Tyriar added this to the 3.11.0 milestone Jan 2, 2019
@Tyriar Tyriar removed the work-in-progress Do not merge label Jan 2, 2019
@Tyriar Tyriar changed the title Experimenting with continuous deployment Setup continuous deployment beta builds Jan 2, 2019
@Tyriar Tyriar requested a review from a team January 26, 2019 21:12
bin/publish.js Outdated Show resolved Hide resolved
@mofux
Copy link
Contributor

mofux commented Jan 29, 2019

LGTM so far. Maybe adding a note about the beta channel to the README would be useful?

@jerch
Copy link
Member

jerch commented Jan 29, 2019

We will need to change our workflow to update the version number immediately after releasing instead of just before a release for this the names to be right.

Isn't this abit unconvenient/error prone to get done right for different release cases, esp. patches? Ive never done the release things, still can image that one can easily mix up things here. Would it be easier to calculate the next version number from the existing, e.g. with the help of node-semver?

@Tyriar Tyriar mentioned this pull request Feb 1, 2019
4 tasks
@Tyriar Tyriar modified the milestones: 3.11.0, 3.12.0 Feb 1, 2019
@Tyriar Tyriar modified the milestones: 3.12.0, 3.13.0 Mar 8, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Mar 8, 2019

Isn't this abit unconvenient/error prone to get done right for different release cases, esp. patches? Ive never done the release things, still can image that one can easily mix up things here. Would it be easier to calculate the next version number from the existing, e.g. with the help of node-semver?

My suggestion aligned with how VS Code does it which works pretty well, if the "error" case does happen it doesn't really matter that much, it just means that 3.12.0-betaX was released instead of 3.13.0-beta1. We could add this to the releasing guide (and maybe automate it away eventually) https://github.com/xtermjs/xterm.js/wiki/Releasing

@Tyriar
Copy link
Member Author

Tyriar commented Mar 8, 2019

I'm not sure if we will want to keep this long term, but it would be a really good way to test out the process for automating stable releases.

@Tyriar Tyriar removed this from the 3.13.0 milestone Apr 12, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Apr 28, 2019

Isn't this abit unconvenient/error prone to get done right for different release cases, esp. patches? Ive never done the release things, still can image that one can easily mix up things here. Would it be easier to calculate the next version number from the existing, e.g. with the help of node-semver?

After thinking about it more I decided to calculate the next version based on the current version and bumping the minor version. That way we can keep the current system of committing the version number when it's being released.

@Tyriar Tyriar added this to the 3.13.0 milestone Apr 28, 2019
@Tyriar Tyriar merged commit f4bbfc3 into xtermjs:master Apr 28, 2019
@Tyriar Tyriar deleted the cd branch April 28, 2019 01:34
@Tyriar Tyriar mentioned this pull request May 10, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants