Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove font-family from .css file #1936

Merged
merged 3 commits into from
Feb 11, 2019
Merged

Remove font-family from .css file #1936

merged 3 commits into from
Feb 11, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 11, 2019

Fixes #1935

@Tyriar Tyriar added this to the 3.12.0 milestone Feb 11, 2019
@Tyriar Tyriar self-assigned this Feb 11, 2019
@Tyriar Tyriar requested a review from mofux February 11, 2019 14:05
@Tyriar
Copy link
Member Author

Tyriar commented Feb 11, 2019

@mofux fixed the IME issue by setting the font 👍

Before:

image

After:

image

mofux
mofux approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@mofux mofux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on OSX 10.14.3 👍

IME composition seems broken on OSX for some reason, but it seems disconnected from this change. I'll file a separate issue for that.

@Tyriar Tyriar merged commit 857ae4b into xtermjs:master Feb 11, 2019
@Tyriar Tyriar deleted the 1935_remove_font_family branch February 11, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofux mofux mofux approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @mofux