Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add underline support to DOM renderer #2014

Merged
merged 1 commit into from
Apr 14, 2019
Merged

feat: add underline support to DOM renderer #2014

merged 1 commit into from
Apr 14, 2019

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Apr 14, 2019

part of #1896

Tyriar
Tyriar requested changes Apr 14, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this also needs a corresponding change to xterm.css

@starpit
Copy link
Contributor Author

starpit commented Apr 14, 2019

doh! thanks for the good eyes, i forgot to commit that part.

@Tyriar Tyriar added this to the 3.13.0 milestone Apr 14, 2019
@Tyriar Tyriar self-assigned this Apr 14, 2019
@Tyriar
Copy link
Member

Tyriar commented Apr 14, 2019

Thanks 🙂

@Tyriar Tyriar merged commit c6f785f into xtermjs:master Apr 14, 2019
@Tyriar Tyriar mentioned this pull request May 10, 2019
Merged
10 tasks
@renovate renovate bot mentioned this pull request Jun 6, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@starpit @Tyriar