Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix what branch coverage is sent with #2088

Merged
merged 1 commit into from
May 16, 2019
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 16, 2019

This should fix the coveralls badge as it appears to be working now, just it's reporting against refs/head/master instead of master

@Tyriar Tyriar added this to the 3.14.0 milestone May 16, 2019
@Tyriar Tyriar self-assigned this May 16, 2019
@Tyriar
Copy link
Member Author

Tyriar commented May 16, 2019

Merging, hopefully it'll work for master :)

@Tyriar Tyriar merged commit 610c4c9 into xtermjs:master May 16, 2019
@Tyriar Tyriar deleted the fix_coveralls branch May 16, 2019 17:47
@Tyriar
Copy link
Member Author

Tyriar commented May 16, 2019

It worked, and we went down 6% since it last worked 😉

Tyriar added a commit to microsoft/xterm.js that referenced this pull request May 21, 2019
Merge pull request xtermjs#2081 from Tyriar/xterm-tests
Merge pull request xtermjs#2085 from Tyriar/a11y_fix
Merge pull request xtermjs#2088 from Tyriar/fix_coveralls
Merge pull request xtermjs#2092 from Tyriar/layering
Merge pull request xtermjs#2094 from Tyriar/2005_colormanager
Merge pull request xtermjs#2096 from Tyriar/render_coordinator
Merge pull request xtermjs#2098 from Tyriar/2093_logo_demo
Merge pull request xtermjs#2100 from Tyriar/2099_pausing
Merge pull request xtermjs#2101 from Tyriar/bad_comment_
Merge pull request xtermjs#2109 from Tyriar/2107_cursor_report
Merge pull request xtermjs#2113 from Tyriar/2111_automate_patch_release
Merge pull request xtermjs#2110 from Tyriar/split_out_integration
Merge pull request xtermjs#2114 from Tyriar/consolidate_api_test_timeout

Diff: xtermjs/xterm.js@2d59185...93c1b89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant