Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC for protected flag #3712

Closed
wants to merge 1 commit into from
Closed

PoC for protected flag #3712

wants to merge 1 commit into from

Conversation

jerch
Copy link
Member

@jerch jerch commented Mar 25, 2022

Currently just a quickly hacked PoC for protected flag support (so far only tested manually on canvas renderer).

@stuboydl: Maybe try this one out?

@Tyriar Tyriar linked an issue Mar 31, 2022 that may be closed by this pull request
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is just a proof of concept, do you think it's worth the extra complexity to support this one? If we can support it so the perf overhead is negligible on print when no protected flags happen then I'm not opposed.

@jerch
Copy link
Member Author

jerch commented Mar 31, 2022

Tbh - I dont know, but lean somewhat more towards no support. Indeed the overhead is not as much as I thought in the beginning, also the code duplication of the PoC can be shortened alot by using some handler arguments.

But I am not sure yet whether the PoC already covers all aspects of the protected flag thingy, thus should be tested first by someone with an actual use case. Without any real world test case there is a high chance we get it partially wrong, or introduce more ugly reworks down the road. Thus my hesitation.

@jerch
Copy link
Member Author

jerch commented Sep 2, 2022

@Tyriar I think I will give this another go, once the other PR #4095 is done. The needed changes seem so small so I dont see a reason not to support it. Still I dont quite grasp the full domain of those protection flags, so this needs some digging through old DEC manuals.

@Tyriar
Copy link
Member

Tyriar commented Sep 2, 2022

@jerch sounds good, it's just one bit and we've got extended attributes working pretty well now

@jerch jerch closed this Sep 3, 2022
@jerch
Copy link
Member Author

jerch commented Sep 4, 2022

Superseeded by #4098.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full support for DECSED,DECSEL,DECSCA, etc for xtermjs
2 participants