Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude box and block glyphs from contrast ratio demands #3844

Merged
merged 6 commits into from
Jun 2, 2022
Merged

exclude box and block glyphs from contrast ratio demands #3844

merged 6 commits into from
Jun 2, 2022

Conversation

meganrogge
Copy link
Member

fix #3843

@meganrogge meganrogge self-assigned this May 31, 2022
@meganrogge meganrogge requested a review from Tyriar May 31, 2022 22:41
@meganrogge meganrogge added this to the 4.19.0 milestone May 31, 2022
@meganrogge meganrogge changed the title exclude box chars from contrast ratio demands exclude box and block glyphs from contrast ratio demands Jun 1, 2022
Tyriar
Tyriar approved these changes Jun 1, 2022
View reviewed changes
src/browser/renderer/RendererUtils.ts Outdated Show resolved Hide resolved
Tyriar
Tyriar requested changes Jun 1, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually not be excluding some of the powerline symbols, the ones that are just icons (0xe0a0-0xe0a3):

image

@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2022 •
edited
Loading

Ha, the tests failed because it's a block character used in the webgl api tests. You can skip the test and create an issue to handle in debt week.

@meganrogge meganrogge merged commit 6b16732 into xtermjs:master Jun 2, 2022
This was referenced Jul 2, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
4.19.0
Development

Successfully merging this pull request may close these issues.

Exclude box drawing characters from min contrast ratio
2 participants
@meganrogge @Tyriar