Custom common powerline glyph rendering #3856
Conversation
|
Clipping is making the line look a bit off:
Not clipping will probably make it look weird, moving it in each side by 1/2 dpr would change the angle slightly but probably look best. |
| * | ||
| * Original symbols defined in https://github.com/powerline/fontpatcher | ||
| */ | ||
| export const powerlineDefinitions: { [index: string]: IVectorShape } = { |
There was a problem hiding this comment.
how does this look when other powerline characters are used alongside of these custom drawn ones?
There was a problem hiding this comment.
It depends on how the glyph gets rendered. This bad example from Windows for example will show the 4 common characters "perfectly" and maybe have the ugly line on the other ones:
No way around this apart from covering those as well, I didn't find a good way to convert a spline set to an svg path though. I wouldn't want to draw a solid vertical line as a workaround either as it will probably fall apart under certain cases; we should either draw everything or pass it off to the browser to draw.
|
Tweaked the outline to have padding on either side:
|
Fixes #3827
Canvas renderer, no powerline symbols in font:
Webgl renderer, no powerline symbols in font:
I ended up just doing the powerline symbols as it was hard to convert the font glyph's spline set to canvas instructions and the main reason we're doing this is to get the powerline to blend in with background cells correctly.