Handle WebGL context loss/restore events in WebGL renderer. #4075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to maintainers: this was originally developed in the context of VS Code's embedded terminal, attempting to make it more robust. It's expected that context losses would be rare, but they can happen due to issues out of the browser's control. If this PR is accepted, I'd be interested in rolling forward VS Code's xterm.js reference and upstreaming the needed patch there to respond to the new |
kenrussell
force-pushed
the
context-restoration
branch
from
a27d32a to
9857457
Compare
|
@Tyriar would you be able to review this? It improves robustness of the Terminal in the face of external graphics issues. |
kenrussell
force-pushed
the
context-restoration
branch
from
9857457 to
23e0f3a
Compare
Tyriar
requested changes
Aug 30, 2022
If the context is restored within a brief period of time (3 seconds), recreate members dependent on WebGL state, and fire onRequestRedraw to the renderer's listeners. Handle changes to the char atlas better in the demo client. Tested in Chrome Canary on macOS by running the demo in one window, and visiting the internal URL about:gpucrash in another window. The terminal now recovers and redraws properly.
kenrussell
force-pushed
the
context-restoration
branch
from
23e0f3a to
9459553
Compare
kenrussell
changed the title
|
Thanks for your review! All feedback addressed. It's much simpler and completely self-contained now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the context is restored within a brief period of time (3 seconds),
recreate members dependent on WebGL state, and fire onRequestRedraw to
the renderer's listeners.
Handle changes to the char atlas better in the demo client.
Tested in Chrome Canary on macOS by running the demo in one window,
and visiting the internal URL about:gpucrash in another window. The
terminal now recovers and redraws properly.