Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bower support, clean up readme #882

Merged
merged 6 commits into from
Aug 16, 2017
Merged

Remove bower support, clean up readme #882

merged 6 commits into from
Aug 16, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 12, 2017

Fixes #406

  • Removed bower from everywhere
  • Removed dist from the repo, it is still in the package.json to be published to npm
  • While removing bower from the readme I reorganized and cleaned it up:
    • Shuffled sections around to prioritize the getting started section and de-prioritize the demo (as that's for xterm.js dev, not usage)
    • Made big changes to the getting started section, put addons and importing underneath it as h3s

@Tyriar Tyriar added this to the 3.0.0 milestone Aug 12, 2017
@Tyriar Tyriar self-assigned this Aug 12, 2017
@Tyriar Tyriar requested a review from parisk August 12, 2017 21:51
@coveralls
Copy link

coveralls commented Aug 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 71.57% when pulling d583163 on Tyriar:406_remove_dist_bower into 91bf319 on sourcelair:v3.

parisk
parisk approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍰

@Tyriar Tyriar merged commit 39328d6 into xtermjs:v3 Aug 16, 2017
@Tyriar Tyriar deleted the 406_remove_dist_bower branch August 16, 2017 15:46
@parisk parisk mentioned this pull request Jan 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @coveralls @parisk