Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to code for null-safety. #3

Closed
wants to merge 1 commit into from

Conversation

asartalo
Copy link
Contributor

@asartalo asartalo commented Feb 26, 2021

  • updated dependencies to use null-safe versions
  • updated code to use null-safe features

Fixes #2

- updated dependencies to use null-safe versions
- updated code to use null-safe features
@asartalo
Copy link
Contributor Author

I've tried to limit the changes to what is only needed to support null-safety. I've only tested this on a local project and it seems to work.

One issue that I found while using the null-safe version is that the hooks will refuse to execute if some of the dependencies in the hooks themselves are not null-safe. This will undoubtedly break projects that haven't opted-in to null-safety.

@asartalo
Copy link
Contributor Author

Hi @xuzhongpeng , do you need this PR to be in the develop branch and not master? Let me know if this is the case and other issues you see in my PR.

@xuzhongpeng
Copy link
Owner

Hi @xuzhongpeng , do you need this PR to be in the develop branch and not master? Let me know if this is the case and other issues you see in my PR.

I have reviewed the codes you pushed. It's running perfectly. But it is only fit SDK >=1.12.0-0 <3.0.0. I may push it in the future, but not now.

@asartalo
Copy link
Contributor Author

asartalo commented Mar 1, 2021

Okay, no problem. It's up to you. :) Just want to let you know that any project that is marked as null-safe by pub.dev like http have to limit their sdk support that way. See http's pubspec.yaml as an example and the documentation on how to migrate packages to null-safety. If you need help with this I will gladly help but it's still up to you.

@xuzhongpeng
Copy link
Owner

Okay, no problem. It's up to you. :) Just want to let you know that any project that is marked as null-safe by pub.dev like http have to limit their sdk support that way. See http's pubspec.yaml as an example and the documentation on how to migrate packages to null-safety. If you need help with this I will gladly help but it's still up to you.

I have pulled your PR to nullSafety channel. I also have created a version 0.1.3-nullsafety.0 to pub.dev. Thank you for your code contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null-safety?
2 participants