Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop Excluding Tests from Coding Standards #1146

Closed
kopepasah opened this issue Jul 21, 2020 · 3 comments
Closed

Stop Excluding Tests from Coding Standards #1146

kopepasah opened this issue Jul 21, 2020 · 3 comments
Assignees
@kopepasah
Labels
enhancement
Milestone
4.0.1

Comments

@kopepasah
Copy link
Contributor

Feature Request

Currently, tests are excluded from the coding standards check: https://github.com/xwp/stream/blob/develop/phpcs.xml.dist#L25

As more tests are being written, we either should not exclude these from this check or create a check to ensure standards are followed in tests as well.
@kopepasah
Copy link
Contributor Author

Specifically relates to #1118, in regards to shorthand vs long form array syntax: #1118 (comment)

@kopepasah kopepasah self-assigned this Aug 1, 2020
@kopepasah
Copy link
Contributor Author

Just adding a note here that I am currently working through adding this functionality, including ensuring current tests meet standards.

@delawski
Copy link
Contributor

This has been done in the 4.0.1 release.

@delawski delawski added this to the 4.0.1 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kopepasah kopepasah

Labels
enhancement
Projects
None yet
Milestone
4.0.1
Development

No branches or pull requests
2 participants
@delawski @kopepasah