ACF connector test implemented and ACF v5.x support added

[kidunot89]

Partially fixes #1093
Fixes and closes #1122

Summary

• Updates the ACF connector class to work with the changes made in ACF v5+
• Adds tests for ACF v5+ connector logic.
• Adds wpackagist repository and wpackagist-plugin/advanced-custom-fields dev dependency to the composer.json.
• Updates tests bootstrap file to activate plugins defined in the PHPUnit const WP_TEST_ACTIVATED_PLUGINS

[kopepasah]

@kidunot89 my only concern here is requiring the ACF plugin from Composer for development. If we were to follow this same practice, we could end up with a ton of WordPress plugins we are adding the the Composer config, which are not really required for development, but rather for testing. Installing of these plugins for the PHPUnit tests may better be served in some other scripted process for testing, but would like to hear your thoughts on why this method is prefered.

[kidunot89]

@kopepasah Yes, My plan is to add all the plugins, supported by stream through connectors, to the dev dependencies, and writing an integration test for each connector. My reasoning is simply that it's the best option for testing the connectors while adding some future-proofing when those plugins are updated with breaking changes.

[kasparsd]

@kidunot89 I suspect the failing unit tests are caused by wp-dev-lib copying over the project source files to a different place for the actual test run:

https://github.com/xwp/wp-dev-lib/blob/420f1bac828e105a19a904cab97d042891d4b84e/scripts/check-diff.sh#L757-L765

So none of the dependencies (plugins) are moved over to the same wp-content/plugins directory. This is a great example of the many assumptions wp-dev-lib makes about the project structure.

I guess at this point we can switch to using the Docker test environment on Travis too. There are ways to cache the Docker images once they're built so we should be fine.

[kidunot89]

@kasparsd I don't believe that to be the case due to the fact that the same configurations are being used in the bbPress connector PR and CI is passing 👉 #1120

I'm rebasing the branch to and the latest develop branch commit and repushing to see if that makes a difference here.

[kasparsd]

@kidunot89 Unfortunately this is another issue with wp-dev-lib -- those tests are passing because it didn't even run the tests https://travis-ci.com/github/xwp/stream/jobs/355627134#L490 -- the source "$DEV_LIB_PATH/travis.script.sh" command failed silently...

[kopepasah]

@kidunot89 just a quick question, regarding ACF v5. Do we need to perform any version checks for backwards compatibility or does the functionality simply not exist pre-v5?

[kidunot89]

@kopepasah Pre-v5 functionality exists, it's just not tested, or updated.

[kopepasah]

@kopepasah Pre-v5 functionality exists, it's just not tested, or updated.

Thanks for that information! It is difficult to tell, just by reviewing, which parts are pre-v5 and remain backwards compatible, but as long as you are aware, then that can be resolved when testing the changes.

I added my review and requested just a few changes.

[kidunot89]

@kopepasah I'll add notes in the doc blocks for the pre ACF-v5 callbacks.

[kasparsd]

This looks good @kidunot89! Feel free to merge if there is nothing to add.