-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/3.6.1 #1218
Merged
Merged
Release/3.6.1 #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> error: src refspec 3.5.1 matches more than one https://travis-ci.com/github/xwp/stream/jobs/372078948#L474
…/release-tagging # Conflicts: # local/scripts/dist.sh
Automatically tag releases in the distribution repository
CI locked to composer version 1 until support for composer 2 added.
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <[email protected]>
`wp_stream_fail_php_version` does it itself.
Improve PHP version checking
Bump ini from 1.3.5 to 1.3.8
Update dependency grunt-contrib-compress to v2
Settings connector test implemented.
Installer connector test implemented
Users connector class test implemented.
Editor connector test implemented
Comments connector test implemented
kidunot89
force-pushed
the
release/3.6.1
branch
from
January 16, 2021 01:31
fd9b6d5
to
729d1b8
Compare
kidunot89
force-pushed
the
release/3.6.1
branch
3 times, most recently
from
January 22, 2021 23:57
09a4400
to
0106e74
Compare
kasparsd
reviewed
Feb 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kidunot89 I just noticed that one unit test is failing at PHP 5.6 https://travis-ci.com/github/xwp/stream/jobs/474533888#L534-L542
1) WP_Stream\Test_WP_Stream_Connector_Posts::test_callback_transition_post_status
Expectation failed for method name is equal to <string:log> when invoked 12 time(s)
Parameter 0 for invocation #5 WP_Stream\Connector::log('"%1$s" %2$s published', Array (...), 327, 'post', 'updated', null) does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'"%1$s" %2$s scheduled for %3$s'
+'"%1$s" %2$s published'
/var/www/html/wp-content/plugins/stream-src/connectors/class-connector-posts.php:303
/var/www/html/wp-content/plugins/stream-src/classes/class-connector.php:127
/var/www/html/wp-includes/class-wp-hook.php:287
/var/www/html/wp-includes/class-wp-hook.php:311
/var/www/html/wp-includes/plugin.php:484
/var/www/html/wp-includes/post.php:4902
/var/www/html/wp-includes/post.php:4209
/var/www/html/wp-includes/post.php:4411
/var/www/html/wp-content/plugins/stream-src/tests/tests/connectors/test-class-connector-posts.php:374
Do you know which pull request introduced this? Should we fix it now or can we do it post release?
codeclimate coverage reporter added to .travis.yml
kidunot89
force-pushed
the
release/3.6.1
branch
from
February 11, 2021 14:31
0106e74
to
36080f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #000.
Describe your approach and how it fixes the issue.
Checklist
contributing.md
).Release Changelog
Release Checklist
master
branch.readme.txt
.stream.php
.Stable tag
inreadme.txt
.classes/class-plugin.php
.