Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add port so we can see the database #1533

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

tharsheblows
Copy link
Contributor

Add in ports in docker-compose.yml to allow viewing of the database in, eg, Sequel Ace 😊

@tharsheblows tharsheblows requested a review from delawski July 30, 2024 21:28
@tharsheblows tharsheblows added the tooling Development and deployment tooling improvements label Jul 30, 2024
Copy link
Contributor

@delawski delawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

I think we could also add a phpmyadmin container to have a more integrated and dependency-free way of interacting with the DB, something like:

  phpmyadmin:
    image: phpmyadmin/phpmyadmin:5.2.1
    depends_on:
      - db
    environment:
      VIRTUAL_HOST: phpmyadmin.${DEV_URL:-stream.wpenv.net}
      PMA_HOST: wordpress
      PMA_USER: wordpress
      PMA_PASSWORD: password

What's your take?

Due to the setup of the multisite, it's not possible to use phpmyadmin.stream.wpenv.net to access it.
@tharsheblows
Copy link
Contributor Author

@delawski

I think we could also add a phpmyadmin container ...

Yes! It's available at http://stream.wpenv.net:8080 now. Due to multisite shenanigans, it didn't seem possible as a subdomain😊

Could you test that it works for you?

docker-compose.yml Outdated Show resolved Hide resolved
Co-authored-by: Piotr Delawski <[email protected]>
@tharsheblows tharsheblows merged commit 12ace83 into develop Jul 31, 2024
3 checks passed
@tharsheblows tharsheblows deleted the feature/db-ports-local branch July 31, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Development and deployment tooling improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants