Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Edits Grayed Out #1658

Merged
merged 8 commits into from
Dec 31, 2024
Merged

Conversation

marcinkrzeminski
Copy link
Collaborator

@marcinkrzeminski marcinkrzeminski commented Dec 20, 2024

Fixes #1657

Use alternative hook to track the theme files updates in the Dashboard.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Fix Theme files changes are tracked as expected

@marcinkrzeminski marcinkrzeminski changed the title Fix/1657 theme edits grayed out 1657 Theme Edits Grayed Out Dec 20, 2024
@marcinkrzeminski marcinkrzeminski changed the title 1657 Theme Edits Grayed Out Theme Edits Grayed Out Dec 20, 2024
Copy link
Contributor

@tharsheblows tharsheblows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments but this looks good. I looked it up and the ajax method was added in 4.9 so I think we're safe? It will still work with < WP 4.9 but won't record the changes.

Should we add a "Requires at least" header? I'm not really sure which version that would be though.

connectors/class-connector-editor.php Show resolved Hide resolved
connectors/class-connector-editor.php Show resolved Hide resolved
Copy link
Contributor

@tharsheblows tharsheblows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It all looks good.

@marcinkrzeminski marcinkrzeminski merged commit d344661 into develop Dec 31, 2024
1 check passed
@marcinkrzeminski marcinkrzeminski deleted the fix/1657-theme-edits-grayed-out branch December 31, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme Edits Grayed Out
2 participants