This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Fix broken getCurrentTime() method in Safari #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@delawski fun fact, in Chrome (and Safari) when you supply the |
|
@westonruter wow, I didn't know that making dates work in JS is still a challenge, even though it's 2016 already! If there was a need to do complex operations on dates, I'd suggest investigating one of the date libraries like Moment.js. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Safari, but not other browsers,
new Date( "2016-09-23 14:57:10" )is an Invalid Date. It turns out that includingTdelimiting the date from the time causes it to work in Safari, so this PR implements that.