Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More support for macOS #7

Merged
merged 7 commits into from
Jul 17, 2024
Merged

More support for macOS #7

merged 7 commits into from
Jul 17, 2024

Conversation

ryota2357
Copy link
Contributor

Thank you for the great tool!!

Currently:

This PR allows testing on x86 and adds arm64 releases.

I have tested this on both x84 and arm64.

@xyproto
Copy link
Owner

xyproto commented Jul 16, 2024

Thanks for the PR! Only the latest version of Go needs to be supported, if it makes things easier.

@ryota2357
Copy link
Contributor Author

Thank you for your quick response!
I have updated the dependency versions.

I could not understand why CI was failing. I hope this update will solve the problem...

@ryota2357
Copy link
Contributor Author

I'm sorry, I didn't know that macos-14-large needs to payment.
I will remove it.

@xyproto
Copy link
Owner

xyproto commented Jul 17, 2024

I updated the CI configuration in the main branch to use the latest versions, then rebased this branch.

@xyproto
Copy link
Owner

xyproto commented Jul 17, 2024

I wasn't aware of the macos-14-large payment either.

Thanks for the work on this PR. 👍

it needs payment
@xyproto xyproto merged commit 48dc908 into xyproto:main Jul 17, 2024
9 checks passed
@xyproto
Copy link
Owner

xyproto commented Jul 17, 2024

Merged, thanks!

Unfortunately, I see now that I gave the commit a bit inaccurate description. I can mention the correct thing in the changelog / next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants