Use oxidize-rb/actions/cross-gem@v1 instead of oxidize-rb/cross-gem-action@main #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
force-pushed
the
sh-gem-release-port-gem-action
branch
from
928bd49 to
30d0c58
Compare
|
I think we need oxidize-rb/rb-sys#493 for this to work. |
|
Now we need a release of |
…ction@main https://github.com/oxidize-rb/cross-gem-action has been archived in favor of https://github.com/oxidize-rb/actions/tree/main/cross-gem. This commit also: 1. Drops `x64-mingw32` from a precompiled build. As https://github.com/rake-compiler/rake-compiler-dock says: > x64-mingw-ucrt should be used for Ruby 3.1 and later on windows. x64-mingw32 should be used for Ruby 3.0 and earlier. This is to match the changed platform of RubyInstaller-3.1. 2. Use `RakeCompilerDock.ruby_cc_version` to set `RUBY_CC_VERSION` so we don't have to worry about which patch versions can build. 3. Update rb-sys to v0.9.110 to fix build issues with GNU and musl builds. While we're at it, update all Cargo dependencies.
stanhu
force-pushed
the
sh-gem-release-port-gem-action
branch
from
30d0c58 to
8ebcf17
Compare
|
@eliias This is finally ready! I tested the build and release workflow: https://github.com/y-crdt/yrb/actions/runs/13085400141 |
This was referenced Feb 1, 2025
Closed
stanhu
commented
Feb 1, 2025
|
|
||
| spec.add_development_dependency "base64" | ||
| spec.add_development_dependency "rake-compiler", "~> 1.2.1" | ||
| spec.add_development_dependency "rake-compiler-dock", "~> 1.9.1" |
There was a problem hiding this comment.
rb_sys now depends on a specific version of rake-compiler-dock, so let's just use that as the hard dependency.
stanhu
commented
Feb 1, 2025
| require "rake/testtask" | ||
| require "rake/extensiontask" | ||
| require "rb_sys" | ||
|
|
||
| cross_rubies = %w[3.4.0 3.3.5 3.2.0 3.1.0] | ||
| ruby_cc_version = RakeCompilerDock.ruby_cc_version([">= 3.1", "< 3.5"]) |
There was a problem hiding this comment.
rake-compiler-dock now needs exact patch versions, so this method abstracts those details.
|
@eliias I think the build and release workflow is broken until this is merged. Latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/oxidize-rb/cross-gem-action has been archived in favor of https://github.com/oxidize-rb/actions/tree/main/cross-gem.
This commit also:
x64-mingw32from a precompiled build. As https://github.com/rake-compiler/rake-compiler-dock says:Use
RakeCompilerDock.ruby_cc_versionto setRUBY_CC_VERSIONso we don't have to worry about which patch versions can build.Update rb-sys to v0.9.110 to fix build issues with GNU and musl builds. While we're at it, update all Cargo dependencies.