Apply suggestions from code review

Co-authored-by: kirkrodrigues <[email protected]>
y-scope · Jan 19, 2025 · e8560d4 · e8560d4
1 parent 78625a3
commit e8560d4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/components/clp-package-utils/clp_package_utils/scripts/start_clp.py b/components/clp-package-utils/clp_package_utils/scripts/start_clp.py
@@ -939,6 +939,7 @@ def start_log_viewer_webui(
         settings_json_updates["StreamFilesS3PathPrefix"] = (
             f"{s3_config.bucket}/{s3_config.key_prefix}"
         )
+
         access_key_id, secret_access_key = s3_config.get_credentials()
         if access_key_id is not None and secret_access_key is not None:
             container_cmd_extra_opts.extend(

diff --git a/components/log-viewer-webui/server/src/S3Manager.js b/components/log-viewer-webui/server/src/S3Manager.js
@@ -32,6 +32,7 @@ class S3Manager {
      *
      * @param {string} s3uriString The S3 object URI string.
      * @return {Promise<string>} The pre-signed URL string.
+     * @throws {Error} If a pre-signed URL couldn't be generated.
      */
     async getPreSignedUrl (s3uriString) {
         const s3uri = new URL(s3uriString);

diff --git a/components/log-viewer-webui/server/src/routes/query.js b/components/log-viewer-webui/server/src/routes/query.js
@@ -14,7 +14,7 @@ const S3_MANAGER = (
 
 
 /**
- * Submits a stream extraction job and returns the metadata of the extracted stream
+ * Submits a stream extraction job and returns the metadata of the extracted stream.
  *
  * @param {object} props
  * @param {import("fastify").FastifyInstance | {dbManager: DbManager}} props.fastify
@@ -37,18 +37,16 @@ const extractStreamAndGetMetadata = async ({
         streamId: streamId,
         targetUncompressedSize: settings.StreamTargetUncompressedSize,
     });
-
     if (null === extractResult) {
         resp.code(StatusCodes.BAD_REQUEST);
-        throw new Error("Unable to extract stream with " +
-            `streamId=${streamId} at logEventIdx=${logEventIdx}`);
+        throw new Error(`Unable to extract stream with streamId=${streamId} at ` +
+            `logEventIdx=${logEventIdx}`);
     }
 
     const streamMetadata = fastify.dbManager.getExtractedStreamFileMetadata(
         streamId,
         logEventIdx
     );
-
     if (null === streamMetadata) {
         resp.code(StatusCodes.BAD_REQUEST);
         throw new Error("Unable to find the metadata of extracted stream with " +