Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Redis as Celery results backend. #227

Merged
merged 7 commits into from
Jan 28, 2024
Merged

Conversation

gibber9809
Copy link
Contributor

@gibber9809 gibber9809 commented Jan 11, 2024

Description

Add redis to the clp package. Once other changes are ready redis will be swapped for rabbitmq rpc for our celery results backend.

Validation performed

  • verified that redis starts and stops as expected with package scripts
  • verified that search queries execute as expected with the package

@gibber9809 gibber9809 marked this pull request as ready for review January 25, 2024 19:23
@gibber9809 gibber9809 changed the title [WIP] Add redis to the CLP package Add redis to the CLP package Jan 25, 2024
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

Technically, we should use a conceptual component name to avoid having it change if we switched out the underlying implementation; but since we plan to switch away from Celery, using redis as the component name seems fine.

Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message: `Use Redis as Celery results backend. (#227)'?

@gibber9809 gibber9809 merged commit 9e6b755 into y-scope:main Jan 28, 2024
1 check passed
@gibber9809 gibber9809 deleted the add-redis branch January 28, 2024 02:06
@kirkrodrigues kirkrodrigues changed the title Add redis to the CLP package Use Redis as Celery results backend. Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants