fix: Add missing libcurl4 dependency to clp-core and package execution containers.
#670
Conversation
WalkthroughThe pull request introduces the installation of the Changes
The changes are consistent across the relevant files, all involving the inclusion of the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Sorry, I misspoke offline. It's not the execution containers that need libcurl4 (they already have it, although it doesn't hurt to add explicitly), but rather the core container.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
components/core/tools/docker-images/clp-core-ubuntu-focal/Dockerfile (2)
Line range hint
2-9: Consider pinning package versions for reproducible builds.While the package installation works, consider pinning specific versions of all packages (libcurl4, libmariadb-dev, libssl-dev) to ensure reproducible builds and prevent unexpected issues from package updates.
Example:
RUN apt-get update \ && apt-get install -y \ - libcurl4 \ - libmariadb-dev \ - libssl-dev + libcurl4=7.68.0-1ubuntu2.20 \ + libmariadb-dev=1:10.3.38-0ubuntu0.20.04.1 \ + libssl-dev=1.1.1f-1ubuntu2.20
Line range hint
3-4: Consider documenting or addressing the hidden dependency.The TODO comment indicates that libssl-dev is a hidden dependency. Consider:
- Documenting why this dependency is required
- Investigating if it can be made explicit in the package requirements
- Adding tests to validate the dependency relationship
Would you like me to help create an issue to track the investigation of this hidden dependency?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/core/tools/docker-images/clp-core-ubuntu-focal/Dockerfile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: lint-check (ubuntu-latest)
- GitHub Check: build (macos-latest)
- GitHub Check: lint-check (macos-latest)
🔇 Additional comments (1)
components/core/tools/docker-images/clp-core-ubuntu-focal/Dockerfile (1)
7-7: LGTM! Verify package installation in the built image.The addition of libcurl4 as a runtime dependency is correct and aligns with the PR objectives.
Run this script to verify the package installation in the built image:
✅ Verification successful
The libcurl4 package addition is properly implemented.
The package is correctly:
- Added as a runtime dependency in the base stage
- Installed alongside compatible dependencies
- Cleaned up to maintain minimal image size
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify libcurl4 package installation and its dependencies # Note: This assumes the image has been built and tagged as clp-core-ubuntu-focal # Check if libcurl4 is installed and get its version docker run --rm clp-core-ubuntu-focal dpkg-query -W -f='${Package} ${Version}\n' libcurl4 # List all dependencies of libcurl4 docker run --rm clp-core-ubuntu-focal apt-cache depends libcurl4Length of output: 352
Script:
#!/bin/bash # Search for libcurl4 mentions across the codebase echo "=== Searching for libcurl4 mentions ===" rg -i "libcurl4" --type-add 'docker:*.{dockerfile,Dockerfile}' --type docker -C 3 echo -e "\n=== Checking complete Dockerfile content ===" cat components/core/tools/docker-images/clp-core-ubuntu-focal/Dockerfile echo -e "\n=== Looking for related package configurations ===" fd -e json -e yaml -e yml -e conf | xargs rg -l "curl|ssl"Length of output: 1785
gibber9809
changed the title
gibber9809
changed the title
libcurl4 dependency to clp-core and package execution containers.
Description
As pointed out in #669 the core container for the package is missing the libcurl4 dependency. This PR adds libcurl4 to the core container (and explicitly pulls libcurl4 into the execution containers).
Validation performed
Summary by CodeRabbit
libcurl4package to Docker image setup scripts for Ubuntu Focal and Jammy distributions