feat(decoder): Add support for log-level filtering of structured IR streams. #163
Conversation
WalkthroughThis pull request involves a minor version update of the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
33-33: Add a comment explaining the version requirement.Consider adding a comment above the dependency to document why this specific version is required:
+ // Required for structured IR stream filtering support "clp-ffi-js": "^0.3.3",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (2)
package.json (2)
33-33: LGTM! Please verify the changelog for clp-ffi-js.The update to version ^0.3.3 is appropriate for adding the log-level filtering capability. Since this is a pre-1.0 version, the caret (^) will only allow patch updates, which helps maintain stability.
Let's verify the changes between versions:
✅ Verification successful
Version update verified - includes required log-level filtering support
The update to v0.3.3 explicitly adds support for log-level filtering of structured IR streams (PR #35), along with the necessary infrastructure via LogEventWithFilterData template class. Additional improvements include increased WASM memory limit and better bigint handling.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check the changelog and release notes for clp-ffi-js between 0.3.0 and 0.3.3 # Fetch release information from GitHub gh api graphql -f query=' { repository(owner: "y-scope", name: "clp-ffi-js") { releases(first: 4, orderBy: {field: CREATED_AT, direction: DESC}) { nodes { tagName description } } } }'Length of output: 1921
33-33: Review package-lock.json changes.Please ensure that the package-lock.json file has been updated and committed with this change to maintain consistent installations across the team.
✅ Verification successful
package-lock.json is properly updated
The package-lock.json file has been verified to contain the correct version (0.3.3) of clp-ffi-js and includes the proper resolution information.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if package-lock.json exists and contains the updated version # Check if package-lock.json exists and contains the new version if [ -f "package-lock.json" ]; then echo "Checking package-lock.json for clp-ffi-js version..." grep -A 5 '"clp-ffi-js":' package-lock.json else echo "Warning: package-lock.json not found" fiLength of output: 356
Script:
#!/bin/bash # Verify package-lock.json content more precisely if [ -f "package-lock.json" ]; then echo "File size of package-lock.json:" ls -l package-lock.json echo -e "\nSearching for clp-ffi-js in package-lock.json:" # Search with more context and specific pattern grep -A 10 '"clp-ffi-js": {' package-lock.json else echo "package-lock.json not found" fiLength of output: 356
Script:
#!/bin/bash # Check package-lock.json format and search for any mention of clp-ffi-js if [ -f "package-lock.json" ]; then echo "Package-lock.json format version:" grep '"lockfileVersion":' package-lock.json echo -e "\nSearching for any mention of clp-ffi-js:" grep -n "clp-ffi-js" package-lock.json else echo "package-lock.json not found" fiLength of output: 473
Description
PR #85 added support for structured IR streams (IRV2), but did not support filtering. This PR adds filtering support by updating clp-ffi-js to the latest version, which now supports filtering for structured IR streams.
Validation performed
Tested filtering works
Summary by CodeRabbit
clp-ffi-jspackage to version 0.3.3