Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new-log-viewer: Add log query support in
StateContextProvider
. #80new-log-viewer: Add log query support in
StateContextProvider
. #80Changes from 27 commits
49bd9a4
5b48fd3
7a777ee
fdd761a
5e4571a
6be07e9
908ee7a
da20db4
5bf7df1
9a3cca9
8aa0c14
38fe8e1
fb14c88
47c2b82
1286879
ea6b1ee
7ed8baf
46fe49f
9706bd0
8e91e83
8f60afc
3de7f80
3c6c53d
e04f169
e3913d5
b732607
45e5e61
142275e
24e86c8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider refactoring the QUERY_RESULT case for clarity and robustness
The implementation of the
QUERY_RESULT
case is functional, but there are opportunities for improvement:v
for better readability.Map
methods.Here's a suggested refactor:
This refactored version improves readability, simplifies the logic, and adds basic error checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
🛠️ Refactor suggestion
Check warning on line 54 in new-log-viewer/src/services/LogFileManager/index.ts
GitHub Actions / lint-check
Check warning on line 58 in new-log-viewer/src/services/LogFileManager/index.ts
GitHub Actions / lint-check