Smaller bubbles WIP #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A stage in the smaller version bubbles investigation.
Crossgen takes bubbling assemblies and puts them into ApplicationContext structure for further lookup among them.
Global IsInSameVersionBubble(...), Module::IsInCurrentVersionBubble() functions have been updated to provide new logic.
Dozen of conditions used IsLargeVersionBubbleEnabled() have been updated with smaller bubble related logic.
In function ZapInfo::getClassSize turned off actions under condition of crossing version bubble boundaries. In other case compilation falls trying to call a EncodeModuleHelper function pointer previously set to NULL in ZapImportTable::GetCheckTypeLayoutImport(...) function.
Given all this compilation passes, but runtime fails. And R2RDump tool shows that manifest metadata AssemblyRef's contains the same assemblies that it does after Large Version Bubble mode compilation.
Behavior under getClassSize and AssemblyRef content are questions for further investigation.