Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Schked 1.0 #1

Merged
merged 4 commits into from
Oct 19, 2022
Merged

Support Schked 1.0 #1

merged 4 commits into from
Oct 19, 2022

Conversation

bibendi
Copy link
Contributor

@bibendi bibendi commented Oct 19, 2022 •
edited
Loading

@Envek
Copy link
Member

Envek commented Oct 19, 2022

Thanks for the pull request and congrats with schked 1.0!

However, tests are started to fail in redis gem (somewhere under Schked Redis locker). Maybe also add fakeredis to Gemfile?

@skryukov
Copy link
Member

I tried using fakeredis and it doesn't work due to lack of evalsha support (which used in Redlock).

I think I will add dip 😅

@bibendi bibendi mentioned this pull request Oct 19, 2022
Merged
3 tasks
@bibendi
Copy link
Contributor Author

bibendi commented Oct 19, 2022

I made Redis optional in a test environment.
Pushed schked 1.1.0.
I think we can just restart the tests.

@skryukov skryukov merged commit d9ab889 into yabeda-rb:master Oct 19, 2022
@bibendi bibendi deleted the patch-1 branch October 19, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bibendi @Envek @skryukov