Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added qmake project include file #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

richelbilderbeek
Copy link
Contributor

Simple file I use to pack all Meschach files in a qmake project. It is unimportant to cmake users, but I'd like to rely on this file being present for the EDIBLE GitHub.

@richelbilderbeek
Copy link
Contributor Author

P.S. I could understand you'd not want to add this: it would not fit your project description :-)

@yageek
Copy link
Owner

yageek commented May 16, 2017

Why are some files commented ?

@richelbilderbeek
Copy link
Contributor Author

Great question! I commented the files used in applications; those that have a main function. This .pri file contains the library part of Meschach only. Sure I can remove those commented lines, I can do now if you'd prefer to.

@yageek
Copy link
Owner

yageek commented May 16, 2017

May be adding a comment telling which files are removed and why would be nice :)

@richelbilderbeek
Copy link
Contributor Author

Great idea, will do and will reply here when done (the modifications will be added to the Pull Request)

@richelbilderbeek
Copy link
Contributor Author

Done :-)

@richelbilderbeek
Copy link
Contributor Author

My compiler has spotted a copy-paste error.

@richelbilderbeek
Copy link
Contributor Author

My compiler has spotted some unused local variables. I removed them.

@richelbilderbeek
Copy link
Contributor Author

@yageek: what do you think about this Pull Request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants