Skip to content

Commit

Permalink
Lock bigdecimal version to 3.1.4
Browse files Browse the repository at this point in the history
This commit addresses the Rails CI using Ruby master branch failure
because Rails CI enables `RAILS_STRICT_WARNINGS` to raise RuntimeError for warnings.

https://buildkite.com/rails/rails/builds/102621#018c49df-e3de-4c2f-aeb7-6d8f08997da9/1102-1107
```ruby
/rails/activesupport/lib/active_support/core_ext/big_decimal/conversions.rb:4: warning: bigdecimal/util is found in bigdecimal, which will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. (RuntimeError)
```

According to https://bugs.ruby-lang.org/issues/20058 ,
This failure has been triggered since ruby/ruby@cc98265
and it will be addressed once the bigdecimal 3.1.5 is available at rubygems.org .

In the meantime, we can workaround this issue by logking `bigdecimal` version to 3.1.4 or lower.
This commit should be reverted when the `bigdecimal` 3.1.5 is available at rubygems.org .
  • Loading branch information
yahonda committed Dec 12, 2023
1 parent 486c50a commit 04ab0b5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ PATH
marcel (~> 1.0)
activesupport (7.2.0.alpha)
base64
bigdecimal
bigdecimal (< 3.1.5)
concurrent-ruby (~> 1.0, >= 1.0.2)
connection_pool (>= 2.2.5)
drb
Expand Down
2 changes: 1 addition & 1 deletion activesupport/activesupport.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,5 @@ Gem::Specification.new do |s|
s.add_dependency "minitest", ">= 5.1"
s.add_dependency "base64"
s.add_dependency "drb"
s.add_dependency "bigdecimal"
s.add_dependency "bigdecimal", "< 3.1.5"
end

0 comments on commit 04ab0b5

Please sign in to comment.