Short Circuit Filter Expression Security If User Checks would pass/fail. #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…curity evaluation if User Check would pass/fail
|
I like the optimization, and will look again after the new unit tests. |
wcekan
reviewed
Apr 21, 2020
elide-core/src/main/java/com/yahoo/elide/core/VerifyFieldAccessFilterExpressionVisitor.java
Outdated
Show resolved
Hide resolved
added 3 commits
April 21, 2020 15:53
…ide into ShortCircuitRelationshipFetches
wcekan
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Evaluating security for filter expressions currently fetches the relationships involved in the filter expression. This can result in unnecessary database queries if the only security rules are User checks.
Motivation and Context
Remove unnecessary database calls when we can evaluate security statically.
How Has This Been Tested?
Unit Tests - TBD
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.