TANDS-19093-adding-transactionRegistry-interface #1322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklish
requested changes
May 15, 2020
| @@ -0,0 +1,26 @@ | |||
| /* | |||
| * * Copyright 2015, Yahoo Inc. | |||
| package com.yahoo.elide.core; | ||
|
|
||
| /** | ||
| * * Database interface library. |
There was a problem hiding this comment.
Can you remove the extra asterisks?
* Removed redundant fetch join for filters * Removed redundant code Co-authored-by: Aaron Klish <[email protected]>
aklish
reviewed
May 18, 2020
| */ | ||
| public interface TransactionRegistry { | ||
|
|
||
| public static class TransactionEntry { |
There was a problem hiding this comment.
I think we might get build warnings for the lack of javadoc for the inner static class - and also the public methods below. Can we add a bit of documentation?
* Add Eclipse import order * remove extra separator line Co-authored-by: wcekan <[email protected]>
…ithub.com/ramshakr/elide into TANDS-19093-transactionRegistry-Interface
…ithub.com/ramshakr/elide into TANDS-19093-transactionRegistry-Interface
Bumps `metrics.version` from 4.1.6 to 4.1.8. Updates `metrics-core` from 4.1.6 to 4.1.8 - [Release notes](https://github.com/dropwizard/metrics/releases) - [Commits](dropwizard/metrics@v4.1.6...v4.1.8) Updates `metrics-servlets` from 4.1.6 to 4.1.8 - [Release notes](https://github.com/dropwizard/metrics/releases) - [Commits](dropwizard/metrics@v4.1.6...v4.1.8) Updates `metrics-servlet` from 4.1.6 to 4.1.8 - [Release notes](https://github.com/dropwizard/metrics/releases) - [Commits](dropwizard/metrics@v4.1.6...v4.1.8) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Aaron Klish <[email protected]>
…ithub.com/ramshakr/elide into TANDS-19093-transactionRegistry-Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1292 (if appropriate)
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.