Elide-Testing Refactor BookAuthorIT & AuditIT #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hellohanchen
commented
Aug 12, 2019
hellohanchen
commented
- Update BookAuthorIT with new integration test framework and Junit 5. Refactor IT Tests (ResourceIT and test infrastructure). #897
- Add jsonData() method to jsonApiDSL
hellohanchen
changed the title
aklish
requested changes
Aug 12, 2019
...elide-test-helpers/src/main/java/com/yahoo/elide/contrib/testhelpers/jsonapi/JsonApiDSL.java
Outdated
Show resolved
Hide resolved
hellohanchen
changed the title
hellohanchen
commented
Aug 13, 2019
|
|
||
| Assert.assertFalse(logger.logMessages.contains("Inverse entities: [Value: update id 1 through id 2 relationship: 2]")); | ||
| assertFalse(logger.logMessages.contains("Inverse entities: [Value: updated value relationship: 2]")); |
There was a problem hiding this comment.
The log message here is changed because this test doesn't depend on testAuditWithDuplicateLineageEntry() anymore.
aklish
approved these changes
Aug 14, 2019
aklish
added a commit
that referenced
this pull request
Sep 3, 2019
* Plumbed/hacked out basic concepts. Elide build working with partial tests for ResourceIT Refactored one ResourceIT test to use the new test DSL Added capabilities to compare documents to test DSL. Added relationship support to DSL Added failure tests First 20 tests rewritten Refactored tests for include testing Cleanup to use static DSL definitions Up to 31 tests refactored Added in memory store harness for IT tests. By default, this harness runs when no harness is specified. Build now passes Refactored 3 more tests Half way 52 tests refactored 65 tests now passing. Migrated InheritanceIT and LifecycleTestIT to new framework Refactored entity dictionary to include support for setting and getting values. The in memory store now uses this functionality to correctly set the ID for generated IDs 67 tests now pass 68 passing 10 tests left Only 3 to go All tests now pass * Removing unused JSON resource files * Minor pre-inspection cleanup * Migrated DataStoreIT tests to new framework * Migrated AnyPolymorphismIT to new framework * Migrated EmbeddedIT to new framework * Migrated AssignedID and FieldLevelIT tests to new framework * Migrated UserTypeIT to new framework * Migrated UserTypeIT, MapEnumIT, and GenerateIT to use new framework * Migrated ShareableIT to new framework * Fixed checkstyles * Fixed legit codacy issues * To-one Relation Test (#899) * To-one Relation Test * Add a test * Address comments from @aklish * Added more JSON-API DSL test * Elide-Testing Refactor access integration test (#911) * Elide-Testing Refactor access integration test * Add setup * Elide-Testing Refactor BookAuthorIT & AuditIT (#909) * Book Author IT refactor * Elide-Testing Refactor audit integration test * Update auditIT * remove json files * make auditIT tests independent * FilterIT integration tests code complete (#917) * Fixed build issues * Refactor sorting it (#918) * Added SortingIt integration test * Deleted groovy file and put json request in seperate file * Remove testng classes * Rebase and fix checkstyle violation * Issue 912 Refactor Error IT Tests (#919) * Add patch extension to DSL (#921) * Refactor Paginate IT (#931) - Upgrade to rest assured 4.x - Fix style issues - Refactor Paginate IT * Implement GraphQL DSL (#903) * GraphQL - Implement query DSL & Remove Groovy tests * Consolidate GraphQL and Relay DSL & serialize object data using lombok and Jackson * Migrate from testng to junit5 * Replace ValueWithVariable interface with plain Java objects * Consolidate to have a single 'Field' class * Consolidate entity and field * Consolidate field and responseField * Remove OperationDefinition interface * Implement Query and Mutation * style * style * Remove extra query/response parameter * javadoc & style * style * Address comments * Address comments * Address comments * Migrated BridgeableStoreIT to new framework. Fixed build issues from last commit. * Started making changes to run IT tests using Junit 5 * Hibernate5 Tests Pass * JPA & Hibernate tests now passing. Removed GraphQLIT. Removed old data store suppliers * Build works. All IT tests run * Removed references to dataStoreSupplier * Disable check only on test framework * disable .NET scan * Inherit versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.