Fix GraphQL Nested UPDATE bug. #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklish
changed the title
|
Can we use the new function here? if (requestScope.getNewPersistentResources().contains(resource))to if (resource.isNewlyCreated()) |
wcekan
approved these changes
Sep 19, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GraphQL during an UPDATE or UPSERT of a nested entity will attempt to add the nested entity to its parent relationship. This is unnecessary for UPDATE (and also UPSERT where the object already exists).
Normally, this would be harmless, but SharePermission barfs.
Motivation and Context
Explained above.
How Has This Been Tested?
All existing GraphQL tests pass.
Manually tested the fix in another project. Note - SharePermission is being removed in Elide 5.0 - so this bug would never have manifested.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.