Avoid calling setState when component is being unmounted #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids an issue where you have a parent and a child both listening to the same store, where parent could re-render in the middle of handling the change event causing the child to be unmounted. When this happens, the child's call to
setState
will cause a warning.It's important to note here that the
isMounted()
may be removed in the future: https://facebook.github.io/react/docs/component-api.html#ismounted. If this happens we will either need to implement our own flag (usingcomponentWillUnmount
) or hope that an alternative is found. See facebook/react#2787 for discussion on this warning and whether it's needed or not.Also fixes YahooArchive/fluxible-router#18