Allow passing new props to updateInitialDimension #34
+13
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
componentWillReceiveProps
happens it callsupdateInitialDimension
to get new dimensions.However, to calculate these new dimensions,
updateInitialDimension
callsgetTopPosition
andgetBottomBoundary
, which both read information from the old props.This PR allows an optional object to be passed to
updateInitialDimension
so the new props values can be given to the other functions.