Feature request: Avoid unfriendly CS territory in pathfinding

[hackedpassword]

Before creating

• This is NOT a gameplay feature from Civ VI, BNW, or outside - see Roadmap
• This is NOT a gameplay feature from Vanilla Civ V or from G&K - If so, it should be a comment in Missing features from Civ V - G&K #4697

Problem Description

Hills and forests etc incur a movement penalty/cost of 2, thus movement calculations will route around these tiles if there's a lower cost route. CS territory does not appear to be considered when routing a path, so CS territory is disrespected, which becomes a relations issue for non-friendly CS's when ending movement in their territory.

Related Issue Links

No response

Desired Solution

A couple suggestions for when a path to the destination is found to cross through unfriendly CS territory:

1. Treat non-friendly CS borders like rivers or embarking, incurring some negligible cost deterring pathfinding through
2. Same, but applied to CS owned tiles

Any added cost shouldn't affect movement reachability, so maybe +0.01 per CS tile. If this concurs.

Alternative Approaches

Same as above broken down into 3 UI selectable options:

1. deter - lowest cost
2. prevent - medium cost
3. avoid - pathfinding only considers CS territory if the destination tile is owned by the CS

Additional Context

I wonder if such checks could be made possible with performance in mind. But would there be a performance hit if those tiles were internally layered into the same movement cost consideration as any other terrain/feature (avoiding a per-tile ownership {invoking hash map madness!} check).

[yairm210]

If your point is to improve the pathfinding, the title is misleading

A quick win is avoiding similar paths, which we can do by ordering the tiles we check
But even this is not a guarantee because the algorithm stops checking after it finds one optimal path, even if there could be another optimal path that also doesn't go through CS territory - it just makes it more likely

[hackedpassword]

Improving pathfinding isn't the goal, the algorithm does a fantastic job of that already. This is about being smarter, like avoiding zone of control.

[yairm210]

That's part of the pathfinding algorithm though
You don't want the travel to ACTUALLY be longer, only for the pathfinding to treat it as such

[hackedpassword]

Added to 4.14.19? That's awesome. I think this will have a subtle positive effect on player and cpu civ management across the board for all players.

I've been looking at the commits, and walked the code tree looking to see what changed maybe gaining a glimpse of further understanding how this AI pathfinding change thing works as coded... but I didn't find anything. How does something like this get implemented but not show up in the code? Maybe client side library builds? idk :(

[yairm210]

Not sure what you mean, shows up for me here
https://github.com/yairm210/Unciv/blob/master/core/src/com/unciv/logic/map/mapunit/movement/UnitMovement.kt

https://github.com/yairm210/Unciv/commits/master/core/src/com/unciv/logic/map/mapunit/movement/UnitMovement.kt