UnitTable: show a summary when no unit is selected

[sulai]

Changes

• When nothing is selected, show idle and waiting units, together with the cycle buttons
• allows to start cycling anytime with the arrow buttons and the shortcuts ,.
• Refactor UnitTable to have separate Presenters for units, cities, spies and no selection.
• at the cost of making private tables internal in order to populate them from the Presenters

[sulai]

UnitTable mixes logic, UI and data, which is not ideal, but it also handled all different entities in one class. I separated out the Presenters for units, cities, spies and non-selection, so it is easier to extend and work with now. It's not perfect though, because it still mixes logic, UI and data, but I didn't want to rewrite everything at the risk of breaking things.

[yairm210]

Separating "presenters" -> Fantastic 👍🏿
I don't like the with{} and let{} but as a temporary measure for separation I'm fine with it

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[yairm210]

Self conflicts

[github-actions]

Conflicts have been resolved.

[yairm210]

Wait, what is the X for? Does it close it?

[sulai]

That's an old screenshot and got fixed, that window never shows an (x).

Also the unit panel in general has a lot of potential. I wish I had more time for unciv 🙂