Added an UniqueType to Found puppet city. #12834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of running away Settler unit will now settle on best tile in dangerous Tiles without escort instead of running away.
with "Founds a new puppet city" in "uniques" of an unit in Units.json. Making it so you can now settle a puppet city.
SeventhM
reviewed
Jan 22, 2025
Comment on lines
-42
to
+46
| val unique = UnitActionModifiers.getUsableUnitActionUniques(unit, UniqueType.FoundCity) | ||
| .firstOrNull() ?: return null | ||
| // FoundPuppetCity is to found a puppet city for modding. | ||
| val unique = UnitActionModifiers.getUsableUnitActionUniques(unit, | ||
| UniqueType.FoundCity).firstOrNull() ?: | ||
| UnitActionModifiers.getUsableUnitActionUniques(unit, | ||
| UniqueType.FoundPuppetCity).firstOrNull() ?: return null |
There was a problem hiding this comment.
I kinda feel like if there's going to be a unique for founding puppets, it should be as a separate option from founding regular cities. This here instead makes it only one or the other (preferring non puppet uniques), which imo might not match a modder's intent
There was a problem hiding this comment.
Hmm so to be able to have the two unique at one ?
There was a problem hiding this comment.
I think for now we can add this, if there's anyone in the future who wants a unit with both for some reason we can change it then
yairm210
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with "Founds a new puppet city" in "uniques" of an unit in Units.json. You can now settle a puppet city.