Resize map with drag gesture #12858
Merged
Resize map with drag gesture #12858
+331
−216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Interesting 😎 |
sulai
force-pushed
the
resize-mini-map
branch
from
2f207bf to
33c2e8f
Compare
|
Conflicts have been resolved. |
sulai
force-pushed
the
resize-mini-map
branch
from
385051c to
1ea9f24
Compare
|
The PR is feature complete and ready for review 😄 |
yairm210
reviewed
Jan 28, 2025
yairm210
reviewed
Jan 28, 2025
| minimap.touchable = Touchable.disabled | ||
| [email protected] { | ||
| touchable = Touchable.enabled | ||
| onClick(toggle) |
There was a problem hiding this comment.
So... If we call getMaximizeToggleButton twice, then two toggle actions would have been added to the minimap holder
Does this mean they'll both activate and cancel out?
There was a problem hiding this comment.
No because getMaimizeToggleButton is not called twice. I think you might refer to the two onActivation calls: they also won't trigger at the same time, because in case the whole map acts as click area, the button is invisible. But I'll restructure that part a bit to make it less confusing 👍
yairm210
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole minimap is a drag area which resizes the mini-map. Very useful on android to have a glimpse on the map, then move it back to where it was.
Bildschirmaufzeichnung.vom.2025-01-24.15-11-29.webm
Added an icon to indicate a resize handle to visualize that this is now possible. And another button which toggles full screen. Full screen collapses as soon as the player chooses a location to show. If map size is really small, no map buttons are shown to keep vision free and the whole area counts as click area to toggle the maximized map.