exception-handling #134
Merged
exception-handling #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit includes: * fix rebase botches * add exnref type * validation for new opcodes * make a few trace messages a bit easier to read
now the simple cases like the following is working.
```
(module
(tag $e (param i32))
(func $g (param i32)
local.get 0
throw $e
)
(func $f (param i32) (result i32)
block (result i32)
try_table (catch $e 0)
local.get 0
call $g
end
unreachable
end
)
(func (export "_start")
i32.const 1234
call $f
i32.const 1234
i32.ne
if
unreachable
end
)
)
```
implement exnref and use it for throw. to make it easier to implement throw_ref. this can also save malloc/free.
wabt (wat2wasm) doesn't support the latest exception-handling yet. while we can use wasm-tools instead, at this point, i don't want to make the ci install it.
Closed
This was referenced Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is based on the latest version of the proposal.
cf. an incomplete attempt based on an older version of proposal: #10