update injectCode.ts to append code when closing tags not detected #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trusktr
commented
Feb 5, 2025
Comment on lines
-116
to
+120
| if (!inject.injectTag) return next() | ||
| else { | ||
| res.type('html') | ||
| res.setHeader('Content-Length', inject.data.length) | ||
| res.send(inject.data) | ||
| } | ||
| res.type('html') | ||
| res.setHeader('Content-Length', inject.data.length) | ||
| res.send(inject.data) |
There was a problem hiding this comment.
The conditional check here is removed because now the injection always happens, regardless if a closing tag was found or not.
trusktr
commented
Feb 5, 2025
Comment on lines
+51
to
+52
| } else { | ||
| data = data + '\n' + this.code |
There was a problem hiding this comment.
Fall back to appending the injection script if no closing tag is found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces the injector to always inject the fiveserver client script, even if a head/html/body tag is not found.