fix #165: add Key parameter to makePicker
#166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainosk
commented
Feb 14, 2022
| @@ -215,7 +215,8 @@ class Picker { | |||
| actions.add(TextButton( | |||
| style: _getButtonStyle(ButtonTheme.of(context)), | |||
| onPressed: () async { | |||
| if (onConfirmBefore != null && !(await onConfirmBefore!(this, selecteds))) { | |||
| if (onConfirmBefore != null && | |||
| !(await onConfirmBefore!(this, selecteds))) { | |||
| daySuffix, | ||
| hourSuffix, | ||
| minuteSuffix, | ||
| secondSuffix; |
| @@ -1215,7 +1221,7 @@ class DateTimePickerAdapter extends PickerAdapter<DateTime> { | |||
| if (!_needUpdatePrev) { | |||
| // check am/pm before hour-ap | |||
| var ap = _columnType.indexWhere((element) => element == 6); | |||
| if (ap > _columnType.indexWhere((element) => element == 7)) { | |||
| if (ap > _columnType.indexWhere((element) => element == 7)) { | |||
| @@ -1432,7 +1438,8 @@ class DateTimePickerAdapter extends PickerAdapter<DateTime> { | |||
| if (minuteInterval == null || minuteInterval! < 2) | |||
| _text = "${intToStr(index)}${_checkStr(minuteSuffix)}"; | |||
| else | |||
| _text = "${intToStr(index * minuteInterval!)}${_checkStr(minuteSuffix)}"; | |||
| _text = | |||
| "${intToStr(index * minuteInterval!)}${_checkStr(minuteSuffix)}"; | |||
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #165.
I added
keyparameter tomakePickermethod. If I pass consistent key to makePicker, the picker's dragging behavior is not interrupted (this is my expected behavior.)If I call
makePickeronbuildmethod, every build use different key ('ValueKey(this)') forPickerWidgetand this interrupt dragging (scrolling). With this PR, we can assign key forPickerWidgetexplicitly or we can omit key for using conventional key ('ValueKey(this)').👇 is sample code to use this parameter.
If #165 is not correct usage, please close this PR 😢 Thank you ❤️