Skip to content

Commit

Permalink
Mixin: Fix mixin linting
Browse files Browse the repository at this point in the history
In accordance with a new rule introduced as part of grafana/dashboard-linter#79 this is now required. However, for the new rule of `panel-unit-rule` we don't reap any benefits from specifiying a particular unit for our panels, the defaults work perfectly fine so they're ignored.

Signed-off-by: gotjosh <[email protected]>
  • Loading branch information
gotjosh committed Jun 29, 2022
1 parent 3f3e2ce commit c494009
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions doc/alertmanager-mixin/.lint
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,7 @@ exclusions:
entries:
- dashboard: Alertmanager / Overview
reason: multi-select is not always required
panel-units-rule:
entries:
- dashboard: Alertmanager / Overview
reason: Dashboard does not benefit from specific unit specification.
4 changes: 4 additions & 0 deletions doc/alertmanager-mixin/dashboards/overview.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ local graphPanel = grafana.graphPanel;
local alerts =
graphPanel.new(
'Alerts',
description='current set of alerts stored in the Alertmanager',
datasource='$datasource',
span=6,
format='none',
Expand All @@ -54,6 +55,7 @@ local graphPanel = grafana.graphPanel;
local alertsRate =
graphPanel.new(
'Alerts receive rate',
description='rate of successful and invalid alerts received by the Alertmanager',
datasource='$datasource',
span=6,
format='ops',
Expand All @@ -67,6 +69,7 @@ local graphPanel = grafana.graphPanel;
local notifications =
graphPanel.new(
'$integration: Notifications Send Rate',
description='rate of successful and invalid notifications sent by the Alertmanager',
datasource='$datasource',
format='ops',
stack=true,
Expand All @@ -80,6 +83,7 @@ local graphPanel = grafana.graphPanel;
local notificationDuration =
graphPanel.new(
'$integration: Notification Duration',
description='latency of notifications sent by the Alertmanager',
datasource='$datasource',
format='s',
stack=false,
Expand Down

0 comments on commit c494009

Please sign in to comment.