Add signature support for HoverHandler. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks @yaohaizh! I just compared with the Javadoc hover in Eclipse and think we should also fully qualify the mains element name, for extra information:
|
|
I think it's fine to make the pull request against https://github.com/eclipse/eclipse.jdt.ls, it's good. |
|
While trying to understand the problem, can we link this pull request to an issue to help recover the context quicker? |
|
Yes, we can create an issue as well. I created eclipse-jdtls#259 |
Signed-off-by: Yaohai Zheng <[email protected]>
yaohaizh
pushed a commit
that referenced
this pull request
Aug 31, 2017
* add initial debug plugin * add debug project in language server product * add copyright, remove startup class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.