Fix fetching passwords and TOTPs from vault #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've had the same problem - I tried your fork, but still has the same problem. Debugging it, I can see the |
tomoakley
reviewed
Feb 28, 2025
| @@ -48,27 +47,29 @@ main() { | |||
| items="$(op::get_all_items)" | |||
| spinner::stop | |||
|
|
|||
| selected_item="$(echo "$items" | awk -F ',' '{ print $1 }' | fzf "${fzf_opts[@]}")" | |||
| readarray -t selection <<< "$(echo "$items" | awk -F ',' '{ print $1 }' | fzf "${fzf_opts[@]}")" | |||
There was a problem hiding this comment.
this seems to work better for me:
IFS=$'\n' read -r -d '' -a selection < <(echo "$items" | awk -F ',' '{ print $1 }' | fzf "${fzf_opts[@]}")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I've been having issues with autotype and copy to clipboard using the plugin. I found that in some shells using the
echo pass,<entry>andecho totp,<entry>--bindcommands in a subshell did not populate the script variables correctly. I've opted for using the--expectflag tofzf, which always prints the key pressed to select the entry along the entry itself. Then, usingreadarraythis is split into the correct variables again.