-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an isTTY check #3
Conversation
Uhhhh idk how to actually test this against a TTY so I'm just gona fake it I guess. |
This prevents the code from having a negative impact on piped stdio. Refs: nodejs/node#6456 (comment) Refs: nodejs/node#1771 (comment)
@bcoe lmk if it needs a better test. I can't think of one off-hand though that won't break once we patch the issue. |
@Fishrock123 is there a way for us to differentiate between |
@Fishrock123 as an alternative option, perhaps document how
|
No, it's literally the same as far as I know. Maybe if we tweak the stdio settings? But I doubt any of that helps because then there's no way of checking it.. :/ https://nodejs.org/dist/latest-v6.x/docs/api/child_process.html#child_process_options_stdio
I mean we should probably have that too.. |
This prevents the code from having a negative impact on piped stdio.
Refs: nodejs/node#6456 (comment)
Refs: nodejs/node#1771 (comment)
@bcoe