Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Don't apply built-in patches when using node_modules resolver #2711

Closed
2 tasks done
orta opened this issue Apr 7, 2021 · 3 comments
Closed
2 tasks done
Labels
enhancement New feature or request waiting for feedback Will autoclose in a while unless more data are provided

Comments

@orta
Copy link
Contributor

orta commented Apr 7, 2021

  • I'd be willing to implement this feature (contributing guide)
  • This feature is important to have in this repository; a contrib plugin wouldn't do

Describe the user story

The patches to my knowledge are to handle pnp, but when resolving node_modules they shouldn't need to be applied

Sometimes to use a TypeScript beta you have to update yarn #2672 because the patches can't be applied due to changes in the TS codebase. This isn't a critical issue as it's normally likely that someone with experience in both TS + yarn can handle the update but the TS website updates pretty early, and I'd love to be able to have other compiler folks updating the TS version and not have to also handle the yarn update process

Describe the solution you'd like

No user settings in my project

Describe the drawbacks of your solution

Perhaps @yarnpkg/plugin-compat noops when node_modules resolver?

Describe alternatives you've considered

An option/env var which suppresses the patches

@orta orta added the enhancement New feature or request label Apr 7, 2021
@arcanis
Copy link
Member

arcanis commented Apr 7, 2021

Starting from master (3.0-to-be) the builtin patches failing to apply will be a warning rather than an error (#2543). They'll still get applied if possible though, since we want to keep the ability to switch between PnP and nm without changing the lockfile.

@arcanis arcanis added the waiting for feedback Will autoclose in a while unless more data are provided label Apr 7, 2021
@orta
Copy link
Contributor Author

orta commented Apr 7, 2021

👍🏻 that works for me

@merceyz
Copy link
Member

merceyz commented Apr 7, 2021

Perfect, I'll close this then 👍

@merceyz merceyz closed this as completed Apr 7, 2021
milesrichardson added a commit to splitgraph/splitgraph.com that referenced this issue Jul 6, 2021
Core problem is that `yarn berry`, when using `pnp` mode, requires
a patch to `typescript`. But we're using the `node-modules` linker.
Need to upgrade yarn I think

Tracking issues:
    - yarnpkg/berry#2935
    - yarnpkg/berry#2543
    - yarnpkg/berry#2711
milesrichardson added a commit to splitgraph/splitgraph.com that referenced this issue Jul 7, 2021
Core problem is that `yarn berry`, when using `pnp` mode, requires
a patch to `typescript`. But we're using the `node-modules` linker.
Need to upgrade yarn I think

Tracking issues:
    - yarnpkg/berry#2935
    - yarnpkg/berry#2543
    - yarnpkg/berry#2711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting for feedback Will autoclose in a while unless more data are provided
Projects
None yet
Development

No branches or pull requests

3 participants