Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements getAllLocators #1838

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Implements getAllLocators #1838

merged 2 commits into from
Sep 14, 2020

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Sep 14, 2020

What's the problem this PR addresses?

FSEvents currently iterates over the packages by crawling the tree recursively. While it's a valid strategy (although we're visiting too many nodes, cf #1826), it's also somewhat overkill since the PnP API already has the list of all locators.

How did you fix it?

Implements a getAllLocators function that returns the list of locators from the internal state. I tried using a generator, but raw arrays ended up being faster, and probably more convenient anyway.

Supercedes #1826

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I have verified that all automated PR checks pass.

@arcanis arcanis merged commit 2cd4827 into master Sep 14, 2020
@arcanis arcanis deleted the mael/get-dependency-locators branch September 14, 2020 14:38
@arcanis arcanis mentioned this pull request Sep 14, 2020
3 tasks
yoannmoinet pushed a commit to yoannmoinet/berry that referenced this pull request Sep 21, 2020
@remorses
Copy link

Thank you for the optimization of fsevents-patch

I tired to update yarn to use latest fsevents patch with yarn set version from sources but there is still the old fsevents patch in the .yarn/unplugged folder, even after deleting unplugged folder and reinstalling

How can i update yarn to use the latest fsevents patch?

@arcanis
Copy link
Member Author

arcanis commented Sep 27, 2020

Hey! It turns out I forgot to regenerate the builtin patchfile from the new sources - I'll do it as part of #1886, once it's landed you'll be able to use yarn set version from sources as expected 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants