-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-compat): update fsevents patch for version 2.2.0 #2078
Conversation
@Kizmar @milichev if you want this fix before it's released you can run |
For the record; that branch does work when I |
Throws with
|
Your Yarn version seems to be old enough to be unable to parse the newer configs we have in the repo, you can grab the bundle from the link I provided instead |
I had the latest version of classic. However by the virtue of Are you sure it's because of the version? |
It's the v2 version you have that I was talking about.
We document installing on a per-project basis https://yarnpkg.com/getting-started/install#per-project-install
Just a guess as older versions loaded the config file in strict mode which throws on unknown values |
Any ideas on when we can see this fix in a release? |
Next release should be sometime this month, in the meantime you can run |
@merceyz thanks, yea just keepin an eye on it for when we can revert back to latest |
There is no other way? The version from sources is broken, at least for me, always trowing an error on a JSON.parse from httpUtils when trying to add a new dependency. This version even breaks the set version, with a semver check that forbids going back to berry. |
I also can't use |
@Fernando-Marquardt @alubbe Might be a bug in master, try |
Tried that, but got the same error. I will open an issue about this to avoid going fourth in here, but thanks for the help. |
@Fernando-Marquardt I can't find the issue in regards to the In the meantime @merceyz I tried both
|
It's a V2 command so you need to already be using berry, try this
|
@merceyz we have abandoned the idea of using berry for the time being, we'll wait until the relationship between yarn v2, create-react-app, sass, etc is more stable and less "workaroundy", thanks for the reply though |
This comment has been minimized.
This comment has been minimized.
Ok guys for the life of me I couldn't get it working, so this is what I did. Its the only way I was able to get it to work for some reason. |
This comment has been minimized.
This comment has been minimized.
Just to be clear, I've marked both comments as off-topic since the topic is to add support for 2.2.0 to the fsevents layer, which is now done. Opinions are fine (and can be easily seen by anyone, it's not like I suppressed them), but I want to keep topics focused on this repository - especially within PRs, which are implementation details. The next release, along with the fix, will be shipped in a few days, I just have one remaining PR to review. Until then, feel free to use the "from sources" command. It's almost exactly what will ship anyway. |
What's the problem this PR addresses?
fsevents released version 2.2.0 and the patch is no longer compatible
fsevents/fsevents@2.1.3...v2.2.0
Fixes #2077
Fixes #719 (comment)
Fixes https://github.com/yarnpkg/berry/runs/1348595951?check_suite_focus=true#step:6:112
How did you fix it?
Updated the patch
Checklist